40% OFF EVERYTHING
BLACK FRIDAY SALE
Buy Now

uwp_geodirectory not picking up translation file

This topic contains 16 replies, has 3 voices, and was last updated by  Giri 7 years, 3 months ago.

We have moved to a support ticketing system and our forums are now closed.

Open Support Ticket
  • Author
    Posts
  • July 19, 2017 at 7:09 am #55

    joecam
    Buyer
    Post count: 63

    Hi,

    Congratulation for the amazing plugin, this simplified profile manager is great…

    I am testing the UsersWP with uwp_geodirectory plugin on my localhost, with translation.
    It is not picking up the translation file, and i tried many locations to place the localized file, but still displays everything in English.
    I am not sure that this problem can come from the text-domain setting of the uwp_geodirectory.php file, but there are different names declared then the real directory names, like uwp-gd against uwp_geodirectory, or like uwp_geodirectory againstuwp-geodirectory.
    Could you give me some direction to find the problem?
    Thanks,

    July 19, 2017 at 2:32 pm #57

    Stiofan O’Connor
    Site Admin
    Post count: 22956

    Hi Joe,

    You are right there was a bug with this, i have released 1.0.3 to resolve this.

    Thanks for reporting 🙂

    Stiofan

    July 19, 2017 at 4:26 pm #58

    joecam
    Buyer
    Post count: 63

    Hi Stiofan,

    Awesome…!!! Updated and works nicely…

    I know it is quite early dev stage yet, but let me give you some feedback about translation functionality, maybe those are already known or will be valuable during the polishing…

    – On the invoices tab, there is an INVOICE tag/title/name before the invoice number, and not translated. All others are fine.
    – On the listings tab, it picks up the plural name of of the CPT, and that is not correct in my target language (hungarian), and should be the singular name. Would be nice to choose… (or the “plural_name: %s” format also would give good result)
    – The AVATAR and Banner Image “update links” are not translated
    – The Title of the modal window for the image upload, and the Upload Avatar/Upload Banner buttons also not translated.

    (all items in the .po file translated…)

    I hope this helps in the future development.
    Thanks,

    July 20, 2017 at 5:32 pm #69

    Giri
    Expired Member
    Post count: 3155

    Hi there,

    I have fixed the strings you mentioned.

    Feel free to report if you see more non translation strings.

    Thanks

    July 20, 2017 at 5:40 pm #70

    Giri
    Expired Member
    Post count: 3155

    We already use plural strings for this one. So thats not a bug.

    https://userswp.io/support/wp-content/uploads/sites/15/2017/07/Screen-Shot-2017-07-19-at-22.22.18.png

    July 20, 2017 at 5:58 pm #71

    joecam
    Buyer
    Post count: 63

    Hi Giri,

    Thank you for the info, i will check it soon..
    For your second reply:
    you are right, you use the plural version, but for the hungarian language it SHOULD BE singular if it is in this order (number followed by PLURAL_NAME_OF_CPT – INCORRECT) and (number followed by SINGULAR_NAME_OF_CPT – CORRECT).
    I don’t know how it will be in other languages, it is language specific… This is why i mentioned an option, in the following form it should work:

    PLURAL_NAME_OF_CPT : number (in this case it would be CÉGEK:4, and in english would look like this – PLACES:4, or COMPANIES:4, etc..)

    Anyway, not a big issue, can be customized…

    Will let you know if i will find anything else.
    Thanks

    July 20, 2017 at 6:04 pm #72

    Giri
    Expired Member
    Post count: 3155

    Ok. By the way those strings are coming from the GD CPT addon. So its not uwp related issue.

    Thanks

    July 20, 2017 at 6:17 pm #73

    joecam
    Buyer
    Post count: 63

    yep… you are right.

    August 4, 2017 at 4:16 pm #171

    joecam
    Buyer
    Post count: 63

    Having some time again to work on it, and found one hardcoded text in the /wp-content/plugins/uwp_geodirectory/includes/gd-functions.php, where the INVOICE should be translated. line 820…

    <a href="<?php echo get_the_permalink(); ?>">Invoice <?php echo get_the_title(); ?></a>

    It is in the 1.0.3 version, and i couldn’t find any dev repo – so it might be fixed already…

    Thanks,

    August 4, 2017 at 4:33 pm #173

    Stiofan O’Connor
    Site Admin
    Post count: 22956

    Thanks, i have fixed that now and it will be in the next release 🙂

    Stiofan

    August 4, 2017 at 4:34 pm #174

    joecam
    Buyer
    Post count: 63

    Great! Thanks.

    August 4, 2017 at 4:37 pm #175

    Stiofan O’Connor
    Site Admin
    Post count: 22956

    You are welcome 🙂

    August 5, 2017 at 1:32 pm #186

    joecam
    Buyer
    Post count: 63

    Just found three more in the same file, /wp-content/plugins/uwp_geodirectory/includes/gd-functions.php

    line 417, 491, 629:

    echo "No " . $gd_post_types[$post_type]['labels']['name'] . " found";

    (would be nice to have 1-1 independent translation word for each, the NO and FOUND for the flexible translation)
    Thanks,

    August 5, 2017 at 4:29 pm #187

    Stiofan O’Connor
    Site Admin
    Post count: 22956

    Thanks for reporting, i have flagged this for giri to look at on Monday.

    Thanks,

    Stiofan

    August 7, 2017 at 1:22 pm #198

    Giri
    Expired Member
    Post count: 3155

    Hi joecam,

    I have fixed those strings.

    Please replace those lines with this one.

    

    
echo sprintf( __( "No %s found", 'uwp-gd' ), $gd_post_types[$post_type]['labels']['name']);
    

    You may also have to scan the language files again using poedit. 
    

    If you have no idea what that mean, then please wait till next version.
    

    Thanks
    

		
	
    


    

			
		
	
    • 

	
  • 

		
    Author
    

		
    

			
				Posts
			
		
    

	
    • 





			



	


		Viewing 15 posts - 1 through 15 (of 17 total)
	


	


		

	

	





		
				

			

				

					
We have moved to a support ticketing system and our forums are now closed.

					Open Support Ticket